]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gro: Disable frag0 optimization on IPv6 ext headers
authorHerbert Xu <herbert@gondor.apana.org.au>
Tue, 10 Jan 2017 20:24:15 +0000 (12:24 -0800)
committerJiri Slaby <jslaby@suse.cz>
Thu, 26 Jan 2017 16:40:29 +0000 (17:40 +0100)
commiteaefead383021b1de5802449530640c9064a8222
tree741a63c49c424efe600515d7ef4069ffb4056c8b
parentbb7927f5df7bd4f1814880fb6c794dab8bad24e6
gro: Disable frag0 optimization on IPv6 ext headers

[ Upstream commit 57ea52a865144aedbcd619ee0081155e658b6f7d ]

The GRO fast path caches the frag0 address.  This address becomes
invalid if frag0 is modified by pskb_may_pull or its variants.
So whenever that happens we must disable the frag0 optimization.

This is usually done through the combination of gro_header_hard
and gro_header_slow, however, the IPv6 extension header path did
the pulling directly and would continue to use the GRO fast path
incorrectly.

This patch fixes it by disabling the fast path when we enter the
IPv6 extension header path.

Fixes: 78a478d0efd9 ("gro: Inline skb_gro_header and cache frag0 virtual address")
Reported-by: Slava Shwartsman <slavash@mellanox.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
include/linux/netdevice.h
net/ipv6/ip6_offload.c