]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ethernet: mtk-star-emac: rearm interrupts in rx_poll only when advised
authorLouis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Thu, 24 Apr 2025 08:38:49 +0000 (10:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 May 2025 07:41:40 +0000 (09:41 +0200)
commiteaf24941380160b4e823427a3b0371c50c8bc000
tree597624ff1de62516e0c7819686cc7b71f8d23951
parent94107259f972d2fd896dbbcaa176b3b2451ff9e5
net: ethernet: mtk-star-emac: rearm interrupts in rx_poll only when advised

[ Upstream commit e54b4db35e201a9173da9cb7abc8377e12abaf87 ]

In mtk_star_rx_poll function, on event processing completion, the
mtk_star_emac driver calls napi_complete_done but ignores its return
code and enable RX DMA interrupts inconditionally. This return code
gives the info if a device should avoid rearming its interrupts or not,
so fix this behaviour by taking it into account.

Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250424-mtk_star_emac-fix-spinlock-recursion-issue-v2-2-f3fde2e529d8@collabora.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mediatek/mtk_star_emac.c