]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
USB: serial: keyspan_pda: verify endpoints at probe
authorJohan Hovold <johan@kernel.org>
Tue, 3 Jan 2017 15:39:48 +0000 (16:39 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 26 Jan 2017 16:39:33 +0000 (17:39 +0100)
commiteb0eb124a640c56a7c307c87a5e7150196ae236e
tree4b4cd7d50ad2140d8597ccf0357b3da7168ad366
parentdfdc808d8a49f16409ee2f559c1794876866da20
USB: serial: keyspan_pda: verify endpoints at probe

commit 5d9b0f859babe96175cd33d7162a9463a875ffde upstream.

Check for the expected endpoints in attach() and fail loudly if not
present.

Note that failing to do this appears to be benign since da280e348866
("USB: keyspan_pda: clean up write-urb busy handling") which prevents a
NULL-pointer dereference in write() by never marking a non-existent
write-urb as free.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/usb/serial/keyspan_pda.c