]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cxl/core/regs: Fix usage of map->reg_type in cxl_decode_regblock() before assigned
authorDave Jiang <dave.jiang@intel.com>
Tue, 19 Mar 2024 18:15:08 +0000 (11:15 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2024 09:19:27 +0000 (11:19 +0200)
commiteb0ef4118693caa7ac11c68aeb78d7a4570100bb
treee5a24656d049bb33816409f1ee04944f61094f74
parent645cef136e471a13fc11b99daf2c50deca79ac23
cxl/core/regs: Fix usage of map->reg_type in cxl_decode_regblock() before assigned

[ Upstream commit 5c88a9ccd4c431d58b532e4158b6999a8350062c ]

In the error path, map->reg_type is being used for kernel warning
before its value is setup. Found by code inspection. Exposure to
user is wrong reg_type being emitted via kernel log. Use a local
var for reg_type and retrieve value for usage.

Fixes: 6c7f4f1e51c2 ("cxl/core/regs: Make cxl_map_{component, device}_regs() device generic")
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/cxl/core/regs.c