]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging: comedi: fix clean-up of comedi_class in comedi_init()
authorIan Abbott <abbotti@mev.co.uk>
Fri, 16 Jun 2017 18:35:34 +0000 (19:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Jul 2017 11:04:41 +0000 (13:04 +0200)
commiteb844f27b7b2fefed8f801a45474d711f519f80e
treeee8e41e32f05504f82263c134b520eedb8664a94
parented53d437d6c954eb64ad78dc329b0e101030bd22
staging: comedi: fix clean-up of comedi_class in comedi_init()

commit a9332e9ad09c2644c99058fcf6ae2f355e93ce74 upstream.

There is a clean-up bug in the core comedi module initialization
functions, `comedi_init()`.  If the `comedi_num_legacy_minors` module
parameter is non-zero (and valid), it creates that many "legacy" devices
and registers them in SysFS.  A failure causes the function to clean up
and return an error.  Unfortunately, it fails to destroy the "comedi"
class that was created earlier.  Fix it by adding a call to
`class_destroy(comedi_class)` at the appropriate place in the clean-up
sequence.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/comedi_fops.c