]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ipmi: fix initialization when workqueue allocation fails
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Fri, 17 Dec 2021 15:44:10 +0000 (12:44 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Dec 2021 11:20:46 +0000 (12:20 +0100)
commiteb84855d3e8799b67cdbadc7a5c53997cbfc3580
tree6a7bc7d23378ae1868f0cdd4598baebe4f772ae5
parentdb0d90490674c297a2e15a1ca3e40cd6975c30dc
ipmi: fix initialization when workqueue allocation fails

commit 75d70d76cb7b927cace2cb34265d68ebb3306b13 upstream.

If the workqueue allocation fails, the driver is marked as not initialized,
and timer and panic_notifier will be left registered.

Instead of removing those when workqueue allocation fails, do the workqueue
initialization before doing it, and cleanup srcu_struct if it fails.

Fixes: 1d49eb91e86e ("ipmi: Move remove_work to dedicated workqueue")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: Corey Minyard <cminyard@mvista.com>
Cc: Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
Cc: stable@vger.kernel.org
Message-Id: <20211217154410.1228673-2-cascardo@canonical.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/ipmi/ipmi_msghandler.c