]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ceph: fix memory leak in ceph_direct_read_write()
authorIlya Dryomov <idryomov@gmail.com>
Fri, 6 Dec 2024 16:32:59 +0000 (17:32 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Dec 2024 13:02:19 +0000 (14:02 +0100)
commiteb9041837123f31d5897e99bb761f46cb4ce5859
treed38a4ab784b9fb3f6b68385962c86f23646fa29e
parentcbd952b2c4e6eb5dcfdb931e74eff1607f31b496
ceph: fix memory leak in ceph_direct_read_write()

commit 66e0c4f91461d17d48071695271c824620bed4ef upstream.

The bvecs array which is allocated in iter_get_bvecs_alloc() is leaked
and pages remain pinned if ceph_alloc_sparse_ext_map() fails.

There is no need to delay the allocation of sparse_ext map until after
the bvecs array is set up, so fix this by moving sparse_ext allocation
a bit earlier.  Also, make a similar adjustment in __ceph_sync_read()
for consistency (a leak of the same kind in __ceph_sync_read() has been
addressed differently).

Cc: stable@vger.kernel.org
Fixes: 03bc06c7b0bd ("ceph: add new mount option to enable sparse reads")
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Alex Markuze <amarkuze@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ceph/file.c