]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: ethernet: cortina: Carry over frag counter
authorLinus Walleij <linusw@kernel.org>
Fri, 8 May 2026 22:13:38 +0000 (00:13 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 12 May 2026 13:20:16 +0000 (15:20 +0200)
commitebd8ec2b309e3a447851b456ccaf8fb39f3661e7
tree08dea3d43758a4b01092ff48059b2377c4be3578
parent06937db21ee311ed07eba47954447245041a982d
net: ethernet: cortina: Carry over frag counter

The gmac_rx() NAPI poll function assembles packets in an
SKB from a ring buffer.

If the ring buffer gets completely emptied during a poll cycle,
we exit gmac_rx(), but the packet is not yet completely
assembled in the SKB, yet the fragment counter frag_nr is
reset to zero on the next invocation.

Solve this by making the RX fragment counter a part of the
port struct, and carry it over between invocations.

Reset the fragment counter only right after calling
napi_gro_frags(), on error (after calling napi_free_frags())
or if stopping the port.

Reset it in some place where not strictly necessary just to
emphasize what is going on.

This was found by Sashiko during normal patch review.

Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
Link: https://sashiko.dev/#/patchset/20260505-gemini-ethernet-fix-v2-1-997c31d06079%40kernel.org
Signed-off-by: Linus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20260509-gemini-ethernet-fixes-v1-3-6c5d20ddc35b@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/cortina/gemini.c