]> git.ipfire.org Git - thirdparty/samba.git/commit
projects / thirdparty / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: de80649) | patch
smbd: remove fd_close() from open_directory()
authorRalph Boehme <slow@samba.org>
Thu, 17 Dec 2020 11:41:29 +0000 (12:41 +0100)
committerJeremy Allison <jra@samba.org>
Thu, 17 Dec 2020 18:56:28 +0000 (18:56 +0000)
commitebf37cfc3cb025171e0ceca321b343de82975c42
treeb4e9919294cbdeb239b7c164cfae6c58d3527085tree
parentde806498603b47274f1e4647eeb2a84db2b7319acommit | diff
smbd: remove fd_close() from open_directory()

fd_close() was accidentally added twice by
d00d09fdcf73a5839ae4f82cf8e953bb761bfbfb. If it would have been removed by
5770cdd7635a018817418f58bd37268aedebd6a9 that adds the reopen_from_procfd()
optimisation, all would be fine. But fd_close() still being called before
reopen_from_procfd() means we're closing the pathref fd prevening the
optimisation.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/smbd/open.c diff | blob | blame | history
Mirror of https://github.com/samba-team/samba.git