]> git.ipfire.org Git - thirdparty/openssl.git/commit
Fix strtoul test on alpine/musl
authorNeil Horman <nhorman@openssl.org>
Tue, 23 Jul 2024 15:34:29 +0000 (11:34 -0400)
committerNeil Horman <nhorman@openssl.org>
Wed, 24 Jul 2024 16:03:16 +0000 (12:03 -0400)
commitec1d8ead2855f6cd529f9a1ace0a667f34eefc58
treecc5a6e297c7f64483352157a081e4d7888e09db4
parent14e46600c68ece74970462a60ad20703221747a1
Fix strtoul test on alpine/musl

The strtoul tests that were recently added had a compile time check for
__WORDSIZE to properly determine the string to use for an maximal
unsigned long.  Unfortunately musl libc doesn't define __WORDSIZE so we
were in a position where on that platform we fall to the 32 bit unsigned
long variant, which breaks on x86 platforms.

Fix it by doing a preprocessor comparisong on ULONG_MAX instead.

NOTE: This works because preprocessors do arithmetic evaluation on
macros for every compiler we support.  We should be wary of some more
esoteric compilers though.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from https://github.com/openssl/openssl/pull/24974)
test/strtoultest.c