]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
smb/server: fix potential null-ptr-deref of lease_ctx_info in smb2_open()
authorChenXiaoSong <chenxiaosong@kylinos.cn>
Thu, 22 Aug 2024 08:20:51 +0000 (08:20 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:44:03 +0000 (10:44 +0200)
commitec28c35029b7930f31117f9284874b63bea4f31b
tree5ce618f55fc06ebf2e96aa467959643b7e375d82
parentf27602b63800021dfb1dcdab53068ff1950f0064
smb/server: fix potential null-ptr-deref of lease_ctx_info in smb2_open()

commit 4e8771a3666c8f216eefd6bd2fd50121c6c437db upstream.

null-ptr-deref will occur when (req_op_level == SMB2_OPLOCK_LEVEL_LEASE)
and parse_lease_state() return NULL.

Fix this by check if 'lease_ctx_info' is NULL.

Additionally, remove the redundant parentheses in
parse_durable_handle_context().

Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: Steve French <stfrench@microsoft.com>
[ Drop the parentheses clean-up since the parentheses was introduced by
  c8efcc786146 ("ksmbd: add support for durable handles v1/v2") in v6.9
  Minor context change fixed ]
Signed-off-by: Jianqi Ren <jianqi.ren.cn@windriver.com>
Signed-off-by: He Zhe <zhe.he@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/smb/server/oplock.c
fs/smb/server/smb2pdu.c