]> git.ipfire.org Git - thirdparty/linux.git/commit
smb: client: split cached_fid bitfields to avoid shared-byte RMW races
authorHenrique Carvalho <henrique.carvalho@suse.com>
Tue, 27 Jan 2026 16:01:28 +0000 (13:01 -0300)
committerSteve French <stfrench@microsoft.com>
Sun, 8 Feb 2026 23:07:43 +0000 (17:07 -0600)
commitec306600d5ba7148c9dbf8f5a8f1f5c1a044a241
tree25e80d14dcd3104539534d6b890bbeb259073de1
parent96c4af418586ee9a6aab61738644366426e05316
smb: client: split cached_fid bitfields to avoid shared-byte RMW races

is_open, has_lease and on_list are stored in the same bitfield byte in
struct cached_fid but are updated in different code paths that may run
concurrently. Bitfield assignments generate byte read–modify–write
operations (e.g. `orb $mask, addr` on x86_64), so updating one flag can
restore stale values of the others.

A possible interleaving is:
    CPU1: load old byte (has_lease=1, on_list=1)
    CPU2: clear both flags (store 0)
    CPU1: RMW store (old | IS_OPEN) -> reintroduces cleared bits

To avoid this class of races, convert these flags to separate bool
fields.

Cc: stable@vger.kernel.org
Fixes: ebe98f1447bbc ("cifs: enable caching of directories for which a lease is held")
Signed-off-by: Henrique Carvalho <henrique.carvalho@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/cached_dir.h