]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: microsoft: do not use compound literal - fix build
authorJiri Slaby <jslaby@suse.cz>
Mon, 12 Nov 2012 09:16:09 +0000 (10:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Aug 2013 15:26:27 +0000 (08:26 -0700)
commitec3c697d1904c8c126ac8f88b16949e4c7038c2b
tree35dae219bc73b1ee55fd4c405e8d6099b399c065
parent9eae33247abc89486e375d3ae64702ad25aa08e6
HID: microsoft: do not use compound literal - fix build

commit 6b90466cfec2a2fe027187d675d8d14217c12d82 upstream.

In patch "HID: microsoft: fix invalid rdesc for 3k kbd" I fixed
support for MS 3k keyboards. However the added check using memcmp and
a compound statement breaks build on architectures where memcmp is a
macro with parameters.

hid-microsoft.c:51:18: error: macro "memcmp" passed 6 arguments, but takes just 3

On x86_64, memcmp is a function, so I did not see the error.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-microsoft.c