]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
icmp: randomize the global rate limiter
authorEric Dumazet <edumazet@google.com>
Thu, 15 Oct 2020 18:42:00 +0000 (11:42 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:07:05 +0000 (10:07 +0100)
commitec5c9273f73160a7569896f8bf6af8cdae6fdb93
treead9832261b97877ad2a34196bdc90e7bcb20fa20
parentab91b97c5f924338c2669fd37920b5448d283f5b
icmp: randomize the global rate limiter

[ Upstream commit b38e7819cae946e2edf869e604af1e65a5d241c5 ]

Keyu Man reported that the ICMP rate limiter could be used
by attackers to get useful signal. Details will be provided
in an upcoming academic publication.

Our solution is to add some noise, so that the attackers
no longer can get help from the predictable token bucket limiter.

Fixes: 4cdf507d5452 ("icmp: add a global rate limitation")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Keyu Man <kman001@ucr.edu>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Documentation/networking/ip-sysctl.rst
net/ipv4/icmp.c