]> git.ipfire.org Git - thirdparty/glibc.git/commit
arm: Remove wrong ldr from _dl_start_user (BZ 31339)
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Mon, 5 Feb 2024 16:10:24 +0000 (16:10 +0000)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Mon, 5 Feb 2024 18:43:21 +0000 (15:43 -0300)
commitec6aaab3e1d754a1ad762f9e9ca4e2525ce87ad3
tree6d644a4d8884ef41f936d61223a596cd9a78ed53
parent2853e541c58af1f5d868c4161ea9562e7876a989
arm: Remove wrong ldr from _dl_start_user (BZ 31339)

The commit 49d877a80b29d3002887b084eec6676d9f5fec18 (arm: Remove
_dl_skip_args usage) removed the _SKIP_ARGS literal, which was
previously loader to r4 on loader _start.  However, the cleanup did not
remove the following 'ldr r4, [sl, r4]' on _dl_start_user, used to check
to skip the arguments after ld self-relocations.

In my testing, the kernel initially set r4 to 0, which makes the
ldr instruction just read the _GLOBAL_OFFSET_TABLE_.  However, since r4
is a callee-saved register; a different runtime might not zero
initialize it and thus trigger an invalid memory access.

Checked on arm-linux-gnu.

Reported-by: Adrian Ratiu <adrian.ratiu@collabora.com>
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
(cherry picked from commit 1e25112dc0cb2515d27d8d178b1ecce778a9d37a)
sysdeps/arm/dl-machine.h