]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
selftests: rds: Stop tcpdump on timeout
authorAllison Henderson <achender@kernel.org>
Mon, 4 May 2026 05:41:41 +0000 (22:41 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 6 May 2026 02:19:54 +0000 (19:19 -0700)
commitec91483634fe9ae30ba50bc20e2050ce7eec2e8e
tree5bb37c37c65ef7d7377ecc8e237535a14d1a3654
parentc726bc68fffd2fe031eff258abd1283b063d0880
selftests: rds: Stop tcpdump on timeout

The timeout signal handler for the rds selftests currently just
exits when the time limit is exceeded, and forgets to stop the
network dumps.  Fix this by hoisting the tcpdump terminate commands
into a helper function, and call it from the signal handler before
exiting

Bound proc.wait() with a timeout (and fall back to proc.kill())
so an unresponsive tcpdump cannot hang the timeout path itself.

We also pop() tcpdump_procs as we iterate, so stop_pcaps() is safe
to call from both the normal cleanup path and the signal handler,
since the second invocation simply has nothing to do

Signed-off-by: Allison Henderson <achender@kernel.org>
Link: https://patch.msgid.link/20260504054143.4027538-9-achender@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/rds/test.py