]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nvme: fix the check for duplicate unique identifiers
authorChristoph Hellwig <hch@lst.de>
Thu, 24 Feb 2022 10:32:58 +0000 (11:32 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 11:57:35 +0000 (13:57 +0200)
commiteca2037db0519f41fe0a553a1a05b7c27ce8c3d2
tree5212589b7d0701ad022ccedaaba3939fa3b4f356
parent9d78f9187920980ad19be8d86b4a94811523dc8d
nvme: fix the check for duplicate unique identifiers

[ Upstream commit e2724cb9f0c406b8fb66efd3aa9e8b3edfd8d5c8 ]

nvme_subsys_check_duplicate_ids should needs to return an error if any of
the identifiers matches, not just if all of them match.  But it does not
need to and should not look at the CSI value for this sanity check.

Rewrite the logic to be separate from nvme_ns_ids_equal and optimize it
by reducing duplicate checks for non-present identifiers.

Fixes: ed754e5deeb1 ("nvme: track shared namespaces")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvme/host/core.c