]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
unix_diag: fix incorrect sign extension in unix_lookup_by_ino
authorDmitry V. Levin <ldv@altlinux.org>
Fri, 19 Feb 2016 01:27:48 +0000 (04:27 +0300)
committerJiri Slaby <jslaby@suse.cz>
Wed, 2 Mar 2016 15:29:15 +0000 (16:29 +0100)
commitecee23698c61fb56704d1abb5f083e54a276be29
treeeb2ccedee1fee52a7e8d4b7493ea2c05d71ad6b6
parent7b715d926d6bcd9ad1ccdf436e659aa86eebdeb5
unix_diag: fix incorrect sign extension in unix_lookup_by_ino

[ Upstream commit b5f0549231ffb025337be5a625b0ff9f52b016f0 ]

The value passed by unix_diag_get_exact to unix_lookup_by_ino has type
__u32, but unix_lookup_by_ino's argument ino has type int, which is not
a problem yet.
However, when ino is compared with sock_i_ino return value of type
unsigned long, ino is sign extended to signed long, and this results
to incorrect comparison on 64-bit architectures for inode numbers
greater than INT_MAX.

This bug was found by strace test suite.

Fixes: 5d3cae8bc39d ("unix_diag: Dumping exact socket core")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/unix/diag.c