]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
Input: ipaq-micro-keys - fix potential deadlock
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 10 Jun 2026 06:05:42 +0000 (23:05 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 11 Jun 2026 20:52:09 +0000 (13:52 -0700)
commited0428e92812b5d4e9d5c4cbcab9a4f107137dfc
tree86439fb58498a32fd260dfea6751ea933235e39c
parent6251f7d3472c0409e30f8d6a24f10d33d12e3f9a
Input: ipaq-micro-keys - fix potential deadlock

The driver acquires the micro->lock spinlock in process context (in
micro_key_start() and micro_key_stop()) without disabling interrupts.
However, this lock is also acquired in hardirq context by the MFD core
rx handler (micro_rx_msg()) which is called from the serial ISR.

This can lead to a lock inversion deadlock if the interrupt fires on the
same CPU while the process context holds the lock.

Fix this by using guard(spinlock_irq) instead of guard(spinlock) in
micro_key_start() and micro_key_stop() to disable interrupts while
holding the lock.

Reported-by: sashiko-bot@kernel.org
Assisted-by: Antigravity:gemini-3.5-flash
Link: https://patch.msgid.link/aij-pfaKK-Nna7wf@google.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/ipaq-micro-keys.c