]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.11] gh-108740: Fix "make regen-all" race condition (#108741) (#109021)
authorVictor Stinner <vstinner@python.org>
Wed, 6 Sep 2023 21:00:30 +0000 (23:00 +0200)
committerGitHub <noreply@github.com>
Wed, 6 Sep 2023 21:00:30 +0000 (23:00 +0200)
commited233ddc00afca0fd9affb119b21dd13b8b935fb
treeb6babe21378b3eaed0515273def49e07d04c2c59
parentd631b823116793050fd0416c0ec877ea00cb47de
[3.11] gh-108740: Fix "make regen-all" race condition (#108741) (#109021)

gh-108740: Fix "make regen-all" race condition (#108741)

Fix a race condition in "make regen-all". The deepfreeze.c source and
files generated by Argument Clinic are now generated or updated
before generating "global objects". Previously, some identifiers may
miss depending on the order in which these files were generated.

* "make regen-global-objects": Make sure that deepfreeze.c is
  generated and up to date, and always run "make clinic".
* "make regen-deepfreeze" now only updates deepfreeze.c (C file).
  It doesn't build deepfreeze.o (object) anymore.
* Remove misleading messages in "make regen-global-objects" and
  "make clinic". They are now outdated, these commands are now
  safe to use.

Backport notes:

* Omit Doc/using/configure.rst changes.
* no need to change "make clinic", it didn't run
  generate_global_objects.py script before.

Co-authored-by: Erlend E. Aasland <erlend@python.org>
(cherry picked from commit db1ee6a19ab62191c16ecb732cb4dcaede98a902)
Makefile.pre.in
Misc/NEWS.d/next/Build/2023-09-01-01-39-26.gh-issue-108740.JHExAQ.rst [new file with mode: 0644]
Tools/scripts/freeze_modules.py