]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dmaengine: apple-admac: Avoid accessing registers in probe
authorSasha Finkelstein <fnkl.kernel@gmail.com>
Sun, 24 Nov 2024 15:48:28 +0000 (16:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Jan 2025 09:34:14 +0000 (10:34 +0100)
commited31336f811778cfdb76c6fcecfebf5ed0de4fc3
tree14fd61e9f6907af42530995f7821c754efbd8f69
parentf5d231592430abdae07dd422671b3514e10196f2
dmaengine: apple-admac: Avoid accessing registers in probe

commit 8d55e8a16f019211163f1180fd9f9fbe05901900 upstream.

The ADMAC attached to the AOP has complex power sequencing, and is
power gated when the probe callback runs. Move the register reads
to other functions, where we can guarantee that the hardware is
switched on.

Fixes: 568aa6dd641f ("dmaengine: apple-admac: Allocate cache SRAM to channels")
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Link: https://lore.kernel.org/r/20241124-admac-power-v1-1-58f2165a4d55@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/apple-admac.c