]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/i915/dp: Disable the AUX DPCD probe quirk if it's not required
authorImre Deak <imre.deak@intel.com>
Mon, 9 Jun 2025 12:55:56 +0000 (15:55 +0300)
committerImre Deak <imre.deak@intel.com>
Thu, 12 Jun 2025 17:44:15 +0000 (20:44 +0300)
commited3648b9ec4c040d5eebc9e4b8b9083a68628022
tree6df685dc2e58f2a4d232241c48a5035712ec1b46
parentb87ed522b3643f096ef183ed0ccf2d2b90ddd513
drm/i915/dp: Disable the AUX DPCD probe quirk if it's not required

Reading DPCD registers has side-effects and some of these can cause a
problem for instance during link training. Based on this it's better to
avoid the probing quirk done before each DPCD register read, limiting
this to the monitor which requires it. The only known problematic
monitor is an external SST sink, so keep the quirk disabled always for
eDP and MST sinks. Reenable the quirk after a hotplug event and after
resuming from a power state without hotplug support, until the
subsequent EDID based detection.

v2: Add a helper for determining the need/setting the probing. (Jani)

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://lore.kernel.org/r/20250609125556.109538-2-imre.deak@intel.com
drivers/gpu/drm/i915/display/intel_dp.c
drivers/gpu/drm/i915/display/intel_dp.h
drivers/gpu/drm/i915/display/intel_dp_aux.c
drivers/gpu/drm/i915/display/intel_hotplug.c