]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
firmware: dmi-sysfs: Fix memory leak in dmi_sysfs_register_handle
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 11 May 2022 07:14:19 +0000 (11:14 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 14:53:57 +0000 (16:53 +0200)
commited38d04342dfbe9e5aca745c8b5eb4188a74f0ef
tree97244e38e477b59204457f88a13b4a687586118f
parent12aa6d0e0ab2a3cb7d4a74c5fae148d6f23057fd
firmware: dmi-sysfs: Fix memory leak in dmi_sysfs_register_handle

[ Upstream commit 660ba678f9998aca6db74f2dd912fa5124f0fa31 ]

kobject_init_and_add() takes reference even when it fails.
According to the doc of kobject_init_and_add()

   If this function returns an error, kobject_put() must be called to
   properly clean up the memory associated with the object.

Fix this issue by calling kobject_put().

Fixes: 948af1f0bbc8 ("firmware: Basic dmi-sysfs support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220511071421.9769-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/firmware/dmi-sysfs.c