]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: core: Prevent null pointer dereference in update_port_device_state
authorUdipto Goswami <quic_ugoswami@quicinc.com>
Wed, 10 Jan 2024 09:58:14 +0000 (15:28 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Feb 2024 08:24:57 +0000 (09:24 +0100)
commited85777c640cf9e6920bb1b60ed8cd48e1f4d873
tree4377b1fc24c4f2280e5b0990674db19fecbd8d7a
parent84a13b97e8e2e9898183466e6b86d2c7dad9d057
usb: core: Prevent null pointer dereference in update_port_device_state

commit 12783c0b9e2c7915a50d5ec829630ff2da50472c upstream.

Currently, the function update_port_device_state gets the usb_hub from
udev->parent by calling usb_hub_to_struct_hub.
However, in case the actconfig or the maxchild is 0, the usb_hub would
be NULL and upon further accessing to get port_dev would result in null
pointer dereference.

Fix this by introducing an if check after the usb_hub is populated.

Fixes: 83cb2604f641 ("usb: core: add sysfs entry for usb device state")
Cc: stable@vger.kernel.org
Signed-off-by: Udipto Goswami <quic_ugoswami@quicinc.com>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20240110095814.7626-1-quic_ugoswami@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hub.c