]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: quic: Too much reduced computed space to build handshake packets
authorFrédéric Lécaille <flecaille@haproxy.com>
Fri, 2 Jul 2021 15:20:04 +0000 (17:20 +0200)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Thu, 23 Sep 2021 13:27:25 +0000 (15:27 +0200)
commited9119f39e18d32f5615e2d5a850e4a96371ed8a
treebd807bd95658cc4f1014f9ba5965e67a6a114494
parent82d1daa268944295080f6b688aec1b13ae9f454d
BUG/MINOR: quic: Too much reduced computed space to build handshake packets

Before this patch we reserved 16 bytes (QUIC_TLS_TAG_LEN) before building the
handshake packet to be sure to be able to add the tag which comes with the
the packet encryption, decreasing the end offset of the building buffer by 16 bytes.
But this tag length was taken into an account when calling qc_build_frms() which
computes and build crypto frames for the remaining available room thanks to <*len>
parameter which is the length of the already present bytes in the building buffer
before adding CRYPTO frames. This leaded us to waste the 16 last bytes of the buffer
which were not used.
src/xprt_quic.c