]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
codel: remove sch->q.qlen check before qdisc_tree_reduce_backlog()
authorCong Wang <xiyou.wangcong@gmail.com>
Thu, 3 Apr 2025 21:16:31 +0000 (14:16 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:24:33 +0000 (16:24 +0200)
commiteda741fe155ddf5ecd2dd3bfbd4fc3c0c7dbb450
tree1edf8c747d50c7c74373b1f5658cf6b436e44a5a
parentdb568d2151cd20a1e516b0454eda8a11a948e72a
codel: remove sch->q.qlen check before qdisc_tree_reduce_backlog()

commit 342debc12183b51773b3345ba267e9263bdfaaef upstream.

After making all ->qlen_notify() callbacks idempotent, now it is safe to
remove the check of qlen!=0 from both fq_codel_dequeue() and
codel_qdisc_dequeue().

Reported-by: Gerrard Tai <gerrard.tai@starlabs.sg>
Fixes: 4b549a2ef4be ("fq_codel: Fair Queue Codel AQM")
Fixes: 76e3cc126bb2 ("codel: Controlled Delay AQM")
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250403211636.166257-1-xiyou.wangcong@gmail.com
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sched/sch_codel.c
net/sched/sch_fq_codel.c