]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: uvcvideo: Fix dev_sof filtering in hw timestamp
authorRicardo Ribalda <ribalda@chromium.org>
Wed, 13 May 2026 11:49:20 +0000 (11:49 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Thu, 21 May 2026 19:14:07 +0000 (21:14 +0200)
commitedc1917599c5339aedc83135cade66517e0a2972
tree245d3a3cd39d69ef1dd876cd39cea7b5879d1d01
parenta15b773fe4ffa450b56347cc506b2d1405600f5d
media: uvcvideo: Fix dev_sof filtering in hw timestamp

To avoid filling the clock circular buffer with duplicated data we only
add it if the new value sof is different than the last added sof.

The issue is that we compare the unprocess sof with the processed sof.
If there is a sof_offset, or UVC_QUIRK_INVALID_DEVICE_SOF is enabled,
the comparison will not work as expected.

This patch moves the comparison to the right place.

Fixes: 141270bd95d4 ("media: uvcvideo: Refactor clock circular buffer")
Cc: stable@vger.kernel.org
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Tested-by: Yunke Cao <yunkec@google.com>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Link: https://patch.msgid.link/20260513-uvc-hwtimestamp-v3-1-7a64838b0b02@chromium.org
Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/usb/uvc/uvc_video.c