]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
md/raid5: Ensure stripe_fill happens on non-read IO with journal
authorLogan Gunthorpe <logang@deltatee.com>
Thu, 25 Aug 2022 15:46:27 +0000 (09:46 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:57:55 +0000 (09:57 +0200)
commitedce7cb3d8d10996af86d84dd3334242940e8c80
tree650f790dd5e0b4820029c2b8acc56860b8556d18
parent41ca95033a0c47cd6dace1f0a36a6eb5ebe799e6
md/raid5: Ensure stripe_fill happens on non-read IO with journal

[ Upstream commit e2eed85bc75138a9eeb63863d20f8904ac42a577 ]

When doing degrade/recover tests using the journal a kernel BUG
is hit at drivers/md/raid5.c:4381 in handle_parity_checks5():

  BUG_ON(!test_bit(R5_UPTODATE, &dev->flags));

This was found to occur because handle_stripe_fill() was skipped
for stripes in the journal due to a condition in that function.
Thus blocks were not fetched and R5_UPTODATE was not set when
the code reached handle_parity_checks5().

To fix this, don't skip handle_stripe_fill() unless the stripe is
for read.

Fixes: 07e83364845e ("md/r5cache: shift complex rmw from read path to write path")
Link: https://lore.kernel.org/linux-raid/e05c4239-41a9-d2f7-3cfa-4aa9d2cea8c1@deltatee.com/
Suggested-by: Song Liu <song@kernel.org>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Song Liu <song@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/md/raid5.c