]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
atm: idt77252: fix a memleak in open_card_ubr0
authorZhipeng Lu <alexious@zju.edu.cn>
Thu, 1 Feb 2024 12:41:05 +0000 (20:41 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Feb 2024 07:42:19 +0000 (08:42 +0100)
commitedfd328fe7bd6c0d4370cd009f3fec2285260784
tree3a46b3eead446461f10f66b9e04511eb4275d88c
parente77bf828f1ca1c47fcff58bdc26b60a9d3dfbe1d
atm: idt77252: fix a memleak in open_card_ubr0

[ Upstream commit f3616173bf9be9bf39d131b120d6eea4e6324cb5 ]

When alloc_scq fails, card->vcs[0] (i.e. vc) should be freed. Otherwise,
in the following call chain:

idt77252_init_one
  |-> idt77252_dev_open
        |-> open_card_ubr0
              |-> alloc_scq [failed]
  |-> deinit_card
        |-> vfree(card->vcs);

card->vcs is freed and card->vcs[0] is leaked.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/atm/idt77252.c