]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Lock table in DROP STATISTICS
authorTomas Vondra <tomas.vondra@postgresql.org>
Sun, 19 Nov 2023 20:03:29 +0000 (21:03 +0100)
committerTomas Vondra <tomas.vondra@postgresql.org>
Sun, 19 Nov 2023 20:03:50 +0000 (21:03 +0100)
commitee32b824dcc1c9e7efdc065dd152eed39bd97e13
tree6f623a7ba9d39c454f6e5404790d7d1dcf50c3e8
parentf47482609f26c1ea28a9a7f599f53c6dac427de0
Lock table in DROP STATISTICS

The DROP STATISTICS code failed to properly lock the table, leading to

  ERROR:  tuple concurrently deleted

when executed concurrently with ANALYZE.

Fixed by modifying RemoveStatisticsById() to acquire the same lock as
ANALYZE. This function is called only by DROP STATISTICS, as ANALYZE
calls RemoveStatisticsDataById() directly.

Reported by Justin Pryzby, fix by me. Backpatch through 12. The code was
like this since it was introduced in 10, but older releases are EOL.

Reported-by: Justin Pryzby
Reviewed-by: Tom Lane
Backpatch-through: 12

Discussion: https://postgr.es/m/ZUuk-8CfbYeq6g_u@pryzbyj2023
src/backend/commands/statscmds.c