]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: codecs: wcd939x-sdw: Correct Soundwire ports mask
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 26 Jul 2024 14:10:43 +0000 (16:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:20 +0000 (15:34 +0200)
commitee40a8d9262158f3d4696d71dfd14ebbb238b4e6
treedb4391a20f4473488edae0cadaf9e9c0d614efd1
parent784d7c42ed65053a1cfaa48317228f5754ab7461
ASoC: codecs: wcd939x-sdw: Correct Soundwire ports mask

[ Upstream commit 74a79977c4e1d09eced33e6e22f875a5bb3fad29 ]

Device has up to WCD939X_MAX_TX_SWR_PORTS (or WCD939X_MAX_RX_SWR_PORTS
for sink) number of ports and the array assigned to prop.src_dpn_prop
and prop.sink_dpn_prop has 0..WCD939X_MAX_TX_SWR_PORTS-1 elements.  On
the other hand, GENMASK(high, low) creates an inclusive mask between
<high, low>, so we need the mask from 0 up to WCD939X_MAX_TX_SWR_PORTS-1.

Theoretically, too wide mask could cause an out of bounds read in
sdw_get_slave_dpn_prop() in stream.c, however only in the case of buggy
driver, e.g. adding incorrect number of ports via
sdw_stream_add_slave().

Fixes: be2af391cea0 ("ASoC: codecs: Add WCD939x Soundwire devices driver")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20240726-asoc-wcd-wsa-swr-ports-genmask-v1-3-d4d7a8b56f05@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/wcd939x-sdw.c