]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
udp: fix behavior of wrong checksums
authorEric Dumazet <edumazet@google.com>
Sat, 30 May 2015 16:16:53 +0000 (09:16 -0700)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 15 Jun 2015 18:26:53 +0000 (14:26 -0400)
commitee4ab7d8328b0a505d376b6c08d569778c8689af
tree041935af34a7aa63f496503d93c4104d38f897e1
parentf1394a1d369b927534929c08f209c0237a89420d
udp: fix behavior of wrong checksums

[ Upstream commit beb39db59d14990e401e235faf66a6b9b31240b0 ]

We have two problems in UDP stack related to bogus checksums :

1) We return -EAGAIN to application even if receive queue is not empty.
   This breaks applications using edge trigger epoll()

2) Under UDP flood, we can loop forever without yielding to other
   processes, potentially hanging the host, especially on non SMP.

This patch is an attempt to make things better.

We might in the future add extra support for rt applications
wanting to better control time spent doing a recv() in a hostile
environment. For example we could validate checksums before queuing
packets in socket receive queue.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
net/ipv4/udp.c
net/ipv6/udp.c