]> git.ipfire.org Git - thirdparty/systemd.git/commit
test: Stop using grep -q in integration test
authorDaan De Meyer <daan.j.demeyer@gmail.com>
Wed, 3 Dec 2025 12:36:52 +0000 (13:36 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 10 Dec 2025 11:09:10 +0000 (12:09 +0100)
commitee6b3d1aa2329cddb5867bbc86a4b62983ee56fe
tree3edbf4f0d8d44fccdc8f6985d8547ca76951f8ed
parentd065fdd33765cb65bbff97d0fee01b49e30d023e
test: Stop using grep -q in integration test

When a TTY is attached to the test unit, grep -q will generate SIGPIPE
for the previous command in the pipeline which in combo with `pipefail`
will cause the command to fail with exit status 141 which will fail the
test.

Replace with >/dev/null to avoid this from happening.

See also https://www.gnu.org/software/grep/manual/html_node/Usage.html
> There is a related problem with Bash’s set -e -o pipefail. Since grep
> does not always read all its input, a command outputting to a pipe read
> by grep can fail when grep exits before reading all its input, and the
> command’s failure can cause Bash to exit.

Co-authored-by: Yu Watanabe <watanabe.yu+github@gmail.com>
43 files changed:
docs/CODING_STYLE.md
src/kernel-install/test-kernel-install.sh
test/units/TEST-04-JOURNAL.SYSTEMD_JOURNAL_COMPRESS.sh
test/units/TEST-04-JOURNAL.fss.sh
test/units/TEST-04-JOURNAL.journal.sh
test/units/TEST-07-PID1.exec-context.sh
test/units/TEST-07-PID1.private-bpf.sh
test/units/TEST-10-MOUNT.sh
test/units/TEST-13-NSPAWN.machined.sh
test/units/TEST-17-UDEV.IMPORT.sh
test/units/TEST-17-UDEV.SYSTEMD_WANTS.sh
test/units/TEST-17-UDEV.TAG.sh
test/units/TEST-17-UDEV.rename-netif.sh
test/units/TEST-22-TMPFILES.12.sh
test/units/TEST-26-SYSTEMCTL.sh
test/units/TEST-29-PORTABLE.directory.sh
test/units/TEST-29-PORTABLE.image.sh
test/units/TEST-29-PORTABLE.sh
test/units/TEST-35-LOGIN.sh
test/units/TEST-36-NUMAPOLICY.sh
test/units/TEST-43-PRIVATEUSER-UNPRIV.sh
test/units/TEST-46-HOMED.sh
test/units/TEST-50-DISSECT.dissect.sh
test/units/TEST-50-DISSECT.mountfsd.sh
test/units/TEST-54-CREDS.sh
test/units/TEST-55-OOMD.sh
test/units/TEST-58-REPART.sh
test/units/TEST-59-RELOADING-RESTART.sh
test/units/TEST-60-MOUNT-RATELIMIT.sh
test/units/TEST-62-RESTRICT-IFACES.sh
test/units/TEST-65-ANALYZE.sh
test/units/TEST-70-TPM2.cryptsetup.sh
test/units/TEST-72-SYSUPDATE.sh
test/units/TEST-74-AUX-UTILS.busctl.sh
test/units/TEST-74-AUX-UTILS.firstboot.sh
test/units/TEST-74-AUX-UTILS.userdbctl.sh
test/units/TEST-74-AUX-UTILS.varlinkctl.sh
test/units/TEST-75-RESOLVED.sh
test/units/TEST-80-NOTIFYACCESS.sh
test/units/TEST-87-AUX-UTILS-VM.bootctl.sh
test/units/TEST-87-AUX-UTILS-VM.mount.sh
test/units/TEST-87-AUX-UTILS-VM.validatefs.sh
test/units/util.sh