]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix failure of btree_gin indexscans with "char" type and </<= operators.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 10 Aug 2021 22:10:30 +0000 (18:10 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 10 Aug 2021 22:10:30 +0000 (18:10 -0400)
commiteefa4c2b5ed647fed9795f79ed4287898fae9ce6
tree1898f8b39d92fd538e38b95bc99d74f0849c9f56
parent2b4006920ca0d0a579579aecff65ef7fe81185bb
Fix failure of btree_gin indexscans with "char" type and </<= operators.

As a result of confusion about whether the "char" type is signed or
unsigned, scans for index searches like "col < 'x'" or "col <= 'x'"
would start at the middle of the index not the left end, thus missing
many or all of the entries they should find.  Fortunately, this
is not a symptom of index corruption.  It's only the search logic
that is broken, and we can fix it without unpleasant side-effects.

Per report from Jason Kim.  This has been wrong since btree_gin's
beginning, so back-patch to all supported branches.

Discussion: https://postgr.es/m/20210810001649.htnltbh7c63re42p@jasonk.me
contrib/btree_gin/btree_gin.c
contrib/btree_gin/expected/char.out