]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
task_work: Fix NMI race condition
authorPeter Zijlstra <peterz@infradead.org>
Mon, 22 Sep 2025 13:47:00 +0000 (15:47 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 29 Oct 2025 09:29:54 +0000 (10:29 +0100)
commitef1ea98c8fffe227e5319215d84a53fa2a4bcebc
tree468dc5d84c7f850599920adf7de0610447da83c1
parent34976eaf5f83d2bda76eeb54c5bbcafe87245e82
task_work: Fix NMI race condition

  __schedule()
  // disable irqs
      <NMI>
  task_work_add(current, work, TWA_NMI_CURRENT);
      </NMI>
  // current = next;
  // enable irqs
      <IRQ>
  task_work_set_notify_irq()
  test_and_set_tsk_thread_flag(current,
                                       TIF_NOTIFY_RESUME); // wrong task!
      </IRQ>
  // original task skips task work on its next return to user (or exit!)

Fixes: 466e4d801cd4 ("task_work: Add TWA_NMI_CURRENT as an additional notify mode.")
Reported-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Link: https://patch.msgid.link/20250924080118.425949403@infradead.org
kernel/task_work.c