]> git.ipfire.org Git - thirdparty/squid.git/commit
"ssl_bump none" mode crashes squid
authorChristos Tsantilas <chtsanti@users.sourceforge.net>
Wed, 21 May 2014 06:29:38 +0000 (09:29 +0300)
committerChristos Tsantilas <chtsanti@users.sourceforge.net>
Wed, 21 May 2014 06:29:38 +0000 (09:29 +0300)
commitef27e126884cdf23bb787ddad6e97b43451e5251
tree8d3fa3a7e687a1303afbdd925ce743b5a0376737
parent2da06da0c4e9fec6829c6235045fb40eb0e838b5
"ssl_bump none" mode crashes squid

After r13324 patch the SBuf argument of the ConnStateData::handleReadData member
is used only to check if ConnStateData::In::buf is correctly filled with read
data. ConnStateData::handleReadData considers that the data already written
in ConnStateData::in.buf and checks if the passed Sbuf argument is the
ConnStateData::in.buf:

bool ConnStateData::handleReadData(SBuf *buf)
{
   assert(buf == &in.buf);
   .....

The httpsSslBumpAccessCheckDone function needs to write the CONNECT request
generated internally to force tunnel mode, in ConnStateData::In::buf and then
call ConnStateData::handleReadData method.
src/client_side.cc