]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: pci: lx6464es: fix a debug loop
authorDan Carpenter <error27@gmail.com>
Tue, 31 Jan 2023 10:02:13 +0000 (13:02 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Feb 2023 16:22:25 +0000 (17:22 +0100)
commitef3edede7b732395db145735bf4feaa960573995
tree6ac89fdcf358dd92e6b7ba3887e542405a1cf622
parent3914b71dad5a5527819f82f1d085f0087583bdeb
ALSA: pci: lx6464es: fix a debug loop

[ Upstream commit 5dac9f8dc25fefd9d928b98f6477ff3daefd73e3 ]

This loop accidentally reuses the "i" iterator for both the inside and
the outside loop.  The value of MAX_STREAM_BUFFER is 5.  I believe that
chip->rmh.stat_len is in the 2-12 range.  If the value of .stat_len is
4 or more then it will loop exactly one time, but if it's less then it
is a forever loop.

It looks like it was supposed to combined into one loop where
conditions are checked.

Fixes: 8e6320064c33 ("ALSA: lx_core: Remove useless #if 0 .. #endif")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/Y9jnJTis/mRFJAQp@kili
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/lx6464es/lx_core.c