]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-43284: Update platform.win32_ver to use _syscmd_ver instead of sys.getwindowsvers...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Thu, 22 Apr 2021 17:03:36 +0000 (10:03 -0700)
committerGitHub <noreply@github.com>
Thu, 22 Apr 2021 17:03:36 +0000 (10:03 -0700)
commitef63328b46fe7402794cde51008a47e79f37b153
treea5d37d1f1edec82a88beaeaf3c5d80f46df9315a
parentf7bc44170b4bdd16c46b4b6acf7673ffc24dfb19
bpo-43284: Update platform.win32_ver to use _syscmd_ver instead of sys.getwindowsversion() (GH-25500)

The sys module uses the kernel32.dll version number, which can vary from the "actual" Windows version.
Since the best option for getting the version is WMI (which is expensive), we switch back to launching cmd.exe (which is also expensive, but a lot less code on our part).
sys.getwindowsversion() is not updated to avoid launching executables from that module.
(cherry picked from commit 2a3f4899c63806439e5bcea0c30f7e6a6295a763)

Co-authored-by: Shreyan Avigyan <shreyan.avigyan@gmail.com>
Doc/library/sys.rst
Lib/platform.py
Misc/NEWS.d/next/Library/2021-04-21-14-50-57.bpo-43284.2QZn2T.rst [new file with mode: 0644]