]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ath10k: snoc: fix unbalanced IRQ enable in crash recovery
authorCaleb Connolly <caleb.connolly@linaro.org>
Tue, 18 Mar 2025 20:50:27 +0000 (20:50 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Jun 2025 13:32:25 +0000 (15:32 +0200)
commitef8e4aeab3b51de4fad7bba73ee05d546d0a1812
tree0843cbbb6b451d4ee2489bada08d16f2336f890f
parentb93e6fef4eda48e17d9c642b9abad98a066fd4a3
ath10k: snoc: fix unbalanced IRQ enable in crash recovery

[ Upstream commit 1650d32b92b01db03a1a95d69ee74fcbc34d4b00 ]

In ath10k_snoc_hif_stop() we skip disabling the IRQs in the crash
recovery flow, but we still unconditionally call enable again in
ath10k_snoc_hif_start().

We can't check the ATH10K_FLAG_CRASH_FLUSH bit since it is cleared
before hif_start() is called, so instead check the
ATH10K_SNOC_FLAG_RECOVERY flag and skip enabling the IRQs during crash
recovery.

This fixes unbalanced IRQ enable splats that happen after recovering from
a crash.

Fixes: 0e622f67e041 ("ath10k: add support for WCN3990 firmware crash recovery")
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Tested-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Link: https://patch.msgid.link/20250318205043.1043148-1-caleb.connolly@linaro.org
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/ath/ath10k/snoc.c