]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dmaengine: apple-admac: Avoid accessing registers in probe
authorSasha Finkelstein <fnkl.kernel@gmail.com>
Sun, 24 Nov 2024 15:48:28 +0000 (16:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Jan 2025 09:30:50 +0000 (10:30 +0100)
commitf03e6bb31c83a62ad972777da5e95c239f9747be
tree2e02f343fd26036cff9d56b4bffbcea2dd4ea800
parentc2610aba67ed9cd5eac7e50d897dd04504e6a12a
dmaengine: apple-admac: Avoid accessing registers in probe

commit 8d55e8a16f019211163f1180fd9f9fbe05901900 upstream.

The ADMAC attached to the AOP has complex power sequencing, and is
power gated when the probe callback runs. Move the register reads
to other functions, where we can guarantee that the hardware is
switched on.

Fixes: 568aa6dd641f ("dmaengine: apple-admac: Allocate cache SRAM to channels")
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Link: https://lore.kernel.org/r/20241124-admac-power-v1-1-58f2165a4d55@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/apple-admac.c