]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration/postcopy: Initialize blocktime context only until listen
authorPeter Xu <peterx@redhat.com>
Fri, 13 Jun 2025 14:12:12 +0000 (10:12 -0400)
committerFabiano Rosas <farosas@suse.de>
Fri, 11 Jul 2025 13:37:38 +0000 (10:37 -0300)
commitf07f2a3092b70d407a009dae28b44ecc8fbcffb7
tree6dcfd61ba4251549b8ccda7b46a37b0fc559016d
parentb4c82b428828c0ffff273a49f24a22cb4e18d485
migration/postcopy: Initialize blocktime context only until listen

Before this patch, the blocktime context can be created very early, because
postcopy_ram_supported_by_host() <- migrate_caps_check() can happen during
migration object init.

The trick here is the blocktime context needs system vCPU information,
which seems to be possible to change after that point.  I didn't verify it,
but it doesn't sound right.

Now move it out and initialize the context only when postcopy listen
starts.  That is already during a migration so it should be guaranteed the
vCPU topology can never change on both sides.

While at it, assert that the ctx isn't created instead this time; the old
"if" trick isn't needed when we're sure it will only happen once now.

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20250613141217.474825-10-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
migration/postcopy-ram.c