]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ata: libata-scsi: Fix ata_mselect_control_ata_feature() return type
authorDamien Le Moal <dlemoal@kernel.org>
Fri, 18 Apr 2025 06:40:14 +0000 (15:40 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 May 2025 05:50:48 +0000 (07:50 +0200)
commitf0a1b054871ff86ad25b5bd57874af457f5e42c0
tree9739dfebd64d019af823fa81db71706ca981304f
parentf92d5d7134d1f4e15935d54405f250ebffaa2192
ata: libata-scsi: Fix ata_mselect_control_ata_feature() return type

commit db91586b1e8f36122a9e5b8fbced11741488dd22 upstream.

The function ata_mselect_control_ata_feature() has a return type defined
as unsigned int but this function may return negative error codes, which
are correctly propagated up the call chain as integers.

Fix ata_mselect_control_ata_feature() to have the correct int return
type.

While at it, also fix a typo in this function description comment.

Fixes: df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Igor Pylypiv <ipylypiv@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/ata/libata-scsi.c