]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mlx4: prevent potential use after free in mlx4_en_do_uc_filter()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 30 Sep 2025 12:25:01 +0000 (15:25 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 19 Oct 2025 14:23:08 +0000 (16:23 +0200)
commitf0b8a49cc5eb71826da0ecfe73fe2cc23b7ef655
tree02401b6087cc26769fd0b130cd63dbe7cc536c75
parentb322287100ff5f2ff7729b38680f88216bdcbbe6
net/mlx4: prevent potential use after free in mlx4_en_do_uc_filter()

[ Upstream commit 4f0d91ba72811fd5dd577bcdccd7fed649aae62c ]

Print "entry->mac" before freeing "entry".  The "entry" pointer is
freed with kfree_rcu() so it's unlikely that we would trigger this
in real life, but it's safer to re-order it.

Fixes: cc5387f7346a ("net/mlx4_en: Add unicast MAC filtering")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/aNvMHX4g8RksFFvV@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx4/en_netdev.c