]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: reinforce check of i_dtime when clearing high fields of uid and gid
authorDaeho Jeong <daeho.jeong@samsung.com>
Tue, 6 Sep 2016 02:56:10 +0000 (22:56 -0400)
committerJiri Slaby <jslaby@suse.cz>
Tue, 25 Oct 2016 16:11:19 +0000 (18:11 +0200)
commitf0e1bad85179039f78bc04f05ee0d3d3e62b939e
tree0610ae807fe5bb527736a93e162e45c5eb635e8c
parent393328a0b885f3e7b3ba06f14ce5adad94638250
ext4: reinforce check of i_dtime when clearing high fields of uid and gid

commit 93e3b4e6631d2a74a8cf7429138096862ff9f452 upstream.

Now, ext4_do_update_inode() clears high 16-bit fields of uid/gid
of deleted and evicted inode to fix up interoperability with old
kernels. However, it checks only i_dtime of an inode to determine
whether the inode was deleted and evicted, and this is very risky,
because i_dtime can be used for the pointer maintaining orphan inode
list, too. We need to further check whether the i_dtime is being
used for the orphan inode list even if the i_dtime is not NULL.

We found that high 16-bit fields of uid/gid of inode are unintentionally
and permanently cleared when the inode truncation is just triggered,
but not finished, and the inode metadata, whose high uid/gid bits are
cleared, is written on disk, and the sudden power-off follows that
in order.

Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
Signed-off-by: Hobin Woo <hobin.woo@samsung.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/ext4/inode.c