]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vdpa/mlx5: Fix incorrect error code reporting in query_virtqueues
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Mon, 29 Sep 2025 13:42:53 +0000 (06:42 -0700)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 27 Nov 2025 07:03:06 +0000 (02:03 -0500)
commitf0ea2e91093ac979d07ebd033e0f45869b1d2608
tree8ced99438f20a6454c1034d91a8680a6bf4435de
parentdeb55fc994e3dc38f139c0147c15fc2a9db27086
vdpa/mlx5: Fix incorrect error code reporting in query_virtqueues

When query_virtqueues() fails, the error log prints the variable err
instead of cmd->err. Since err may still be zero at this point, the
log message can misleadingly report a success value 0 even though the
command actually failed.

Even worse, once err is set to the first failure, subsequent logs
print that same stale value. This makes the error reporting appear
one step behind the actual failing queue index, which is confusing
and misleading.

Fix the log to report cmd->err, which reflects the real failure code
returned by the firmware.

Fixes: 1fcdf43ea69e ("vdpa/mlx5: Use async API for vq query command")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20250929134258.80956-1-alok.a.tiwari@oracle.com>
drivers/vdpa/mlx5/net/mlx5_vnet.c