]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
platform/x86: int3472: Fix double free of GPIO device during unregister
authorQiu Wenbo <qiuwenbo@kylinsec.com.cn>
Tue, 28 Oct 2025 06:30:09 +0000 (14:30 +0800)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 28 Oct 2025 15:06:14 +0000 (17:06 +0200)
commitf0f7a3f542c1698edb69075f25a3f846207facba
tree6060c8cd1c0716607ec517590564b873881028d6
parent34cbd6e07fddf36e186c8bf26a456fb7f50af44e
platform/x86: int3472: Fix double free of GPIO device during unregister

regulator_unregister() already frees the associated GPIO device. On
ThinkPad X9 (Lunar Lake), this causes a double free issue that leads to
random failures when other drivers (typically Intel THC) attempt to
allocate interrupts. The root cause is that the reference count of the
pinctrl_intel_platform module unexpectedly drops to zero when this
driver defers its probe.

This behavior can also be reproduced by unloading the module directly.

Fix the issue by removing the redundant release of the GPIO device
during regulator unregistration.

Cc: stable@vger.kernel.org
Fixes: 1e5d088a52c2 ("platform/x86: int3472: Stop using devm_gpiod_get()")
Signed-off-by: Qiu Wenbo <qiuwenbo@kylinsec.com.cn>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Hans de Goede <hansg@kernel.org>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Link: https://patch.msgid.link/20251028063009.289414-1-qiuwenbo@gnome.org
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/int3472/clk_and_regulator.c
include/linux/platform_data/x86/int3472.h