]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
md: don't call spare_active in md_reap_sync_thread if all member devices can't work
authorGuoqing Jiang <jgq516@gmail.com>
Wed, 24 Jul 2019 09:09:21 +0000 (11:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2019 10:30:21 +0000 (12:30 +0200)
commitf14b1b3264a73f2ee398cc92955976df81240f68
tree640e372554cb7b66dd4e1aa04629a2ff25890ce9
parenta6d367a6316783115d7ce994e87f1896e8e5c72e
md: don't call spare_active in md_reap_sync_thread if all member devices can't work

[ Upstream commit 0d8ed0e9bf9643f27f4816dca61081784dedb38d ]

When add one disk to array, the md_reap_sync_thread is responsible
to activate the spare and set In_sync flag for the new member in
spare_active().

But if raid1 has one member disk A, and disk B is added to the array.
Then we offline A before all the datas are synchronized from A to B,
obviously B doesn't have the latest data as A, but B is still marked
with In_sync flag.

So let's not call spare_active under the condition, otherwise B is
still showed with 'U' state which is not correct.

Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/md/md.c