]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ixgbevf: Fix resource leak in ixgbevf_init_module()
authorShang XiaoJing <shangxiaojing@huawei.com>
Mon, 14 Nov 2022 02:57:58 +0000 (10:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Dec 2022 10:23:55 +0000 (11:23 +0100)
commitf166c62cad798c53300b4b327e44300c73ec492d
treeafd117b49e217dbd351f4fd7d04f5dbf0bf75f0a
parent8f7047f418102ff45494f9fe388315ec0fa505e5
ixgbevf: Fix resource leak in ixgbevf_init_module()

[ Upstream commit 8cfa238a48f34038464b99d0b4825238c2687181 ]

ixgbevf_init_module() won't destroy the workqueue created by
create_singlethread_workqueue() when pci_register_driver() failed. Add
destroy_workqueue() in fail path to prevent the resource leak.

Similar to the handling of u132_hcd_init in commit f276e002793c
("usb: u132-hcd: fix resource leak")

Fixes: 40a13e2493c9 ("ixgbevf: Use a private workqueue to avoid certain possible hangs")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c