]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
can: j1939: j1939_sk_send_loop(): fix unable to send messages with data length zero
authorAlexander Hölzl <alexander.hoelzl@gmx.net>
Wed, 5 Feb 2025 17:46:51 +0000 (18:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:50:40 +0000 (12:50 +0100)
commitf1767d255807d14ce6a0db95aab6a03014b10503
tree831d521a87cf044c214784961b1ce8d6673abe87
parentf7a43d1563ac8301664c731fedf6b54510189178
can: j1939: j1939_sk_send_loop(): fix unable to send messages with data length zero

commit 44de577e61ed239db09f0da9d436866bef9b77dd upstream.

The J1939 standard requires the transmission of messages of length 0.

For example proprietary messages are specified with a data length of 0
to 1785. The transmission of such messages is not possible. Sending
results in no error being returned but no corresponding can frame
being generated.

Enable the transmission of zero length J1939 messages. In order to
facilitate this two changes are necessary:

1) If the transmission of a new message is requested from user space
the message is segmented in j1939_sk_send_loop(). Let the segmentation
take into account zero length messages, do not terminate immediately,
queue the corresponding skb.

2) j1939_session_skb_get_by_offset() selects the next skb to transmit
for a session. Take into account that there might be zero length skbs
in the queue.

Signed-off-by: Alexander Hölzl <alexander.hoelzl@gmx.net>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://patch.msgid.link/20250205174651.103238-1-alexander.hoelzl@gmx.net
Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Cc: stable@vger.kernel.org
[mkl: commit message rephrased]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/can/j1939/socket.c
net/can/j1939/transport.c