]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hwmon: (coretemp) Handle frozen hotplug state correctly
authorThomas Gleixner <tglx@linutronix.de>
Wed, 10 May 2017 14:30:12 +0000 (16:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jun 2017 13:07:51 +0000 (15:07 +0200)
commitf17b15c896011bb21aff1d0be64840031fd6fec1
tree39b3c13aa5ddddfb5a36980ccf75e6414e5f6c80
parentdcaa3c1ec9cd5fe1590df26c3e03e8b967ea02d8
hwmon: (coretemp) Handle frozen hotplug state correctly

commit 90b4f30b6d15222a509dacf47f29efef2b22571e upstream.

The recent conversion to the hotplug state machine missed that the original
hotplug notifiers did not execute in the frozen state, which is used on
suspend on resume.

This does not matter on single socket machines, but on multi socket systems
this breaks when the device for a non-boot socket is removed when the last
CPU of that socket is brought offline. The device removal locks up the
machine hard w/o any debug output.

Prevent executing the hotplug callbacks when cpuhp_tasks_frozen is true.

Thanks to Tommi for providing debug information patiently while I failed to
spot the obvious.

Fixes: e00ca5df37ad ("hwmon: (coretemp) Convert to hotplug state machine")
Reported-by: Tommi Rantala <tt.rantala@gmail.com>
Tested-by: Tommi Rantala <tt.rantala@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Cc: "Chen, Yu C" <yu.c.chen@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwmon/coretemp.c